Skip to content

revert(mobile,trpc,auth): back out the pro-plan gate pending testing - #6413

Merged
saddlepaddle merged 2 commits into
mainfrom
revert-mobile-paywall
Aug 13, 2026
Merged

saddlepaddle merged 2 commits into
mainfrom
revert-mobile-paywall

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Aug 13, 2026 •

Copy link
Copy Markdown
Collaborator

Backs out #6411 — merged prematurely before it was tested or the email/password approach was settled. Restores:

  • No paywall tier / screen (mobile is ungated again)
  • emailAndPassword back to dev/preview-only (no credential sign-in in prod)
  • Seed script removed from the repo
  • No mobile plan middleware / client version header
  • store.config.js review posture back to demoRequired: false with the SIWA-instant-account notes (keeps chore(mobile): dynamic store config for demo credentials and version #6412's dynamic config + version pin, which are needed for metadata:push regardless)

The gate implementation is preserved on the mobile-paywall branch for iteration.


Summary by cubic

Reverts the mobile Pro-plan gate and restores ungated mobile behavior pending testing. Previously, mobile required a paid plan and allowed credential sign-in in production; now, mobile is ungated and email/password sign-in is limited to dev/preview. Paywall UI, TRPC gating, seed script, and the mobile client version header are removed; dynamic store config and version pin remain.

  • Mobile: remove paywall route/screen and plan-based navigation; delete the EmailSignInLink; keep pending-deletion guard.
  • Auth: restrict emailAndPassword to dev/preview only; remove the review demo seeding flow and script.
  • TRPC: drop the mobile paywall enforcement and the x-superset-client header from the client.
  • Store config: set demoRequired: false and update review notes.

Required actions:

  • Stop using db:seed-review; remove APP_REVIEW_EMAIL and APP_REVIEW_PASSWORD from CI/secrets.
  • QA: verify social sign-in flows, onboarding empty state, and account deletion; confirm no paywall route is reachable.

Written for commit 7105c80. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features
    • Mobile users can access authenticated app features without a paid-plan paywall.
    • Added account deletion handling with sign-out, data refresh, and return to sign-in.
  • Changes
    • Streamlined mobile sign-in by removing the email sign-in option; social sign-in remains available.
    • Production email/password authentication is no longer available.
    • Updated app review guidance to reflect social sign-in, free account creation, and account deletion.
  • Removed
    • Removed paywall screens and review-account setup tooling.

Reverts #6411 (paywall, prod credential sign-in, seed script, client
header) and restores the ungated review posture in store.config.js
(demoRequired false, SIWA-instant-account notes). The dynamic config
and version pin from #6412 stay. The gate lives on in the
mobile-paywall branch for iteration.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 25fa2a23-d743-4598-a9c8-8fe2167dd5c5

📥 Commits

Reviewing files that changed from the base of the PR and between e0e142e and 7105c80.

📒 Files selected for processing (16)
  • apps/mobile/app/paywall.tsx
  • apps/mobile/lib/trpc/client.ts
  • apps/mobile/screens/(auth)/sign-in/SignInScreen.tsx
  • apps/mobile/screens/(auth)/sign-in/components/EmailSignInLink/EmailSignInLink.tsx
  • apps/mobile/screens/(auth)/sign-in/components/EmailSignInLink/index.ts
  • apps/mobile/screens/(authenticated)/settings/account/AccountSettingsScreen.tsx
  • apps/mobile/screens/(authenticated)/settings/hooks/useDeleteAccount/index.ts
  • apps/mobile/screens/(authenticated)/settings/hooks/useDeleteAccount/useDeleteAccount.ts
  • apps/mobile/screens/RootLayout/RootLayout.tsx
  • apps/mobile/screens/paywall/PaywallScreen.tsx
  • apps/mobile/screens/paywall/index.ts
  • apps/mobile/store.config.js
  • package.json
  • packages/auth/src/seed-review-account.ts
  • packages/auth/src/server.ts
  • packages/trpc/src/trpc.ts
💤 Files with no reviewable changes (10)
  • apps/mobile/screens/paywall/index.ts
  • packages/trpc/src/trpc.ts
  • packages/auth/src/seed-review-account.ts
  • apps/mobile/app/paywall.tsx
  • package.json
  • apps/mobile/screens/(auth)/sign-in/components/EmailSignInLink/index.ts
  • apps/mobile/lib/trpc/client.ts
  • apps/mobile/screens/(auth)/sign-in/SignInScreen.tsx
  • apps/mobile/screens/(auth)/sign-in/components/EmailSignInLink/EmailSignInLink.tsx
  • apps/mobile/screens/paywall/PaywallScreen.tsx

📝 Walkthrough

Walkthrough

The mobile app no longer enforces paid-plan access. It removes paywall and email sign-in screens, limits credential authentication to development and preview environments, adds local account deletion handling, and removes review-account seeding requirements.

Changes

Mobile access and account lifecycle

Layer / File(s) Summary
Authentication and API access policy
packages/auth/src/server.ts, packages/trpc/src/trpc.ts, apps/mobile/lib/trpc/client.ts
Credential authentication is limited to development and Vercel preview environments. Mobile paywall procedure restrictions and the client version header were removed.
Mobile navigation and account deletion
apps/mobile/screens/RootLayout/RootLayout.tsx, apps/mobile/screens/(authenticated)/settings/hooks/useDeleteAccount/*, apps/mobile/screens/(authenticated)/settings/account/AccountSettingsScreen.tsx, apps/mobile/screens/(auth)/sign-in/*, apps/mobile/screens/paywall/*, apps/mobile/app/paywall.tsx
Authenticated routing no longer checks paid-plan status. The paywall and email sign-in components were removed. Account deletion now signs out, clears cached queries, redirects to sign-in, and tracks deletion state.
App Store review configuration
apps/mobile/store.config.js, package.json, packages/auth/src/seed-review-account.ts
Demo-account requirements and credentials were removed from review configuration. The review-account seed script and package command were deleted.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to 7105c

This change restores the previously ungated mobile experience and disables production email/password sign-in without any supplied merge-blocking risk; it is merge-ready after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the revert, affected areas, and reason for removing the pro-plan gate.
Description check ✅ Passed The description explains the rationale and restored behavior, with clear QA actions; explicit test results and checklist items are not included.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-mobile-paywall

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit 982b18a into main Aug 13, 2026
19 checks passed
@Kitenite Kitenite mentioned this pull request Aug 16, 2026
3 tasks done

This branch was previously deployed

1 inactive deployment
preview — 7105c80d Deployed Aug 13, 2026 by saddlepaddle via Deploy Web #7588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant