Repository navigation
revert(mobile,trpc,auth): back out the pro-plan gate pending testing - #6413
Conversation
This reverts commit 7b1844a.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
💤 Files with no reviewable changes (10)
📝 WalkthroughWalkthroughThe mobile app no longer enforces paid-plan access. It removes paywall and email sign-in screens, limits credential authentication to development and preview environments, adds local account deletion handling, and removes review-account seeding requirements. ChangesMobile access and account lifecycle
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This change restores the previously ungated mobile experience and disables production email/password sign-in without any supplied merge-blocking risk; it is merge-ready after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Backs out #6411 — merged prematurely before it was tested or the email/password approach was settled. Restores:
emailAndPasswordback to dev/preview-only (no credential sign-in in prod)store.config.jsreview posture back todemoRequired: falsewith the SIWA-instant-account notes (keeps chore(mobile): dynamic store config for demo credentials and version #6412's dynamic config + version pin, which are needed formetadata:pushregardless)The gate implementation is preserved on the
mobile-paywallbranch for iteration.Summary by cubic
Reverts the mobile Pro-plan gate and restores ungated mobile behavior pending testing. Previously, mobile required a paid plan and allowed credential sign-in in production; now, mobile is ungated and email/password sign-in is limited to dev/preview. Paywall UI, TRPC gating, seed script, and the mobile client version header are removed; dynamic store config and version pin remain.
emailAndPasswordto dev/preview only; remove the review demo seeding flow and script.x-superset-clientheader from the client.demoRequired: falseand update review notes.Required actions:
db:seed-review; removeAPP_REVIEW_EMAILandAPP_REVIEW_PASSWORDfrom CI/secrets.Written for commit 7105c80. Summary will update on new commits.
Summary by CodeRabbit